-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudcore crash when no nodeSelector provide #1913
Comments
/assign |
/assign |
Could we set nodeSelector when add device in https://github.com/kubeedge/kubeedge/blob/master/cloud/pkg/devicecontroller/controller/downstream.go#L337? |
I did some test, if we set nodeSelector when add device, it's OK on device add and update. But, if we want to persist nodeSelector, is it necessary to automatic generate an empty nodeSelector? or just let user do it? |
Thinking about existing users, if we add it in definition, is there issue when upgrade? |
I think it would be OK for existing user. Becasue they cannot have non-nodeselector device in system so far. |
What happened:
when we create a device instance without nodeSelector, cloudcore will crash.
What you expected to happen:
cloudcore works properly on device without nodeselector, or just reject it.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
I think these codes cause the problem
Environment:
cloudcore/edgecore --version
):v.1.3.0
CloudSide Environment:
lscpu
):cat /etc/os-release
):uname -a
):go version
):EdgeSide Environment:
edgecore --version
):lscpu
):cat /etc/os-release
):uname -a
):go version
):The text was updated successfully, but these errors were encountered: