Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix golint warnings #25

Closed
islinwb opened this issue Nov 20, 2018 · 6 comments
Closed

fix golint warnings #25

islinwb opened this issue Nov 20, 2018 · 6 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@islinwb
Copy link
Contributor

islinwb commented Nov 20, 2018

Currently code in many directories (excluding vendor, docs, etc.) fails to pass the golint.

Contributors are very welcome to take part in this work. Just leave the directory you want to fix in this issue.

How to do it?
A simple way is

cd ${GOPATH}/src/github.com/kubeedge/kubeedge
# get gometalinter(https://github.com/alecthomas/gometalinter)
curl -L https://git.io/vp6lP | sh
export PATH=${PATH}:${GOPATH}/src/github.com/kubeedge/kubeedge/bin
gometalinter --disable-all --enable=golint --include=<Directory-You-Want-To-Fix> ./...

Then you'll see warnings if any. Just fix them accordingly.

/cc @m1093782566 @Lion-Wei @stewart-yu

@islinwb islinwb added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Nov 20, 2018
@m1093782566
Copy link

Sounds like a good plan.

@stewart-yu
Copy link
Contributor

IMO, first, fixing all in one PR is OK; secondary, can we add gometalinter in vendor? no need to get it every time we run CI

@m1093782566
Copy link

secondary, can we add gometalinter in vendor? no need to get it every time we run CI

@stewart-yu I think we may need to discuss what should be in vendor? files which are referenced by other codes OR files which are used during building, checking or testing?

@sids-b
Copy link
Member

sids-b commented Jan 15, 2019

@maurya-anuj can you please help with this ?

@m1093782566
Copy link

ping @sids-b @maurya-anuj

Any updates?

@sids-b
Copy link
Member

sids-b commented Jan 18, 2019

ping @sids-b @maurya-anuj

Any updates?

@m1093782566 , PR will be raised by @maurya-anuj for pkg folder next week. After which we can also add golint in CI

maurya-anuj added a commit to maurya-anuj/kubeedge that referenced this issue Jan 23, 2019
fixed golint warnings in cmd beehive and pkg folder

Fixes kubeedge#25
maurya-anuj added a commit to maurya-anuj/kubeedge that referenced this issue Jan 23, 2019
fixed golint warnings in cmd beehive and pkg folder

Fixes kubeedge#25
maurya-anuj added a commit to maurya-anuj/kubeedge that referenced this issue Jan 23, 2019
fixed golint warnings in cmd beehive and pkg folder

Fixes kubeedge#25
maurya-anuj added a commit to maurya-anuj/kubeedge that referenced this issue Jan 23, 2019
Fixed golint warnings in beehive, cmd, pkg folder

Fixes kubeedge#25
maurya-anuj added a commit to maurya-anuj/kubeedge that referenced this issue Jan 23, 2019
Fixed golint warnings in beehive, cmd, pkg folder

Fixes kubeedge#25
maurya-anuj added a commit to maurya-anuj/kubeedge that referenced this issue Jan 23, 2019
Fixed golint warnings in beehive, cmd, pkg folder

Fixes kubeedge#25
maurya-anuj added a commit to maurya-anuj/kubeedge that referenced this issue Jan 24, 2019
Fixed golint warnings in beehive, cmd, pkg folder

Fixes kubeedge#25
maurya-anuj added a commit to maurya-anuj/kubeedge that referenced this issue Jan 24, 2019
Fixed golint warnings in beehive, cmd, pkg folder

Fixes kubeedge#25
maurya-anuj added a commit to maurya-anuj/kubeedge that referenced this issue Jan 24, 2019
Fixed golint warnings in beehive, cmd, pkg folder

Fixes kubeedge#25
kevin-wangzefeng pushed a commit to kevin-wangzefeng/kubeedge that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants