Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup a unused file #1323

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Cleanup a unused file #1323

merged 1 commit into from
Dec 18, 2019

Conversation

FengyunPan2
Copy link
Member

@FengyunPan2 FengyunPan2 commented Dec 17, 2019 •
edited
Loading

cleanup a unused file.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2019
@FengyunPan2 FengyunPan2 mentioned this pull request Dec 17, 2019
Merged
@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 17, 2019
fisherxu
fisherxu reviewed Dec 17, 2019
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file yamlconfigurationsource.go looks no used now, I think we can just delete it.

@FengyunPan2
Copy link
Member Author

@fisherxu That's true, NewYamlConfigurationSource is a unused function.
Can I update this pr to delete the yamlconfigurationsource.go file?

@fisherxu
Copy link
Member

@fisherxu That's true, NewYamlConfigurationSource is a unused function.
Can I update this pr to delete the yamlconfigurationsource.go file?

Sure, just delete it, thanks! :)

@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2019
@FengyunPan2 FengyunPan2 changed the title Close file after invoking os.open() Cleanup a unused file Dec 18, 2019
@fisherxu
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019
@kevin-wangzefeng
Copy link
Member

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2019
@kubeedge-bot kubeedge-bot merged commit d0bb505 into kubeedge:master Dec 18, 2019
@FengyunPan2 FengyunPan2 mentioned this pull request Mar 11, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@chendave chendave Awaiting requested review from chendave

@subpathdev subpathdev Awaiting requested review from subpathdev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FengyunPan2 @fisherxu @kevin-wangzefeng @kubeedge-bot