Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the token separator space to dot #1640

Merged
merged 3 commits into from
May 7, 2020

Conversation

XJangel
Copy link
Contributor

@XJangel XJangel commented May 7, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind feature

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
command line parsing error when using parameter token

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot
Copy link
Collaborator

Welcome @XJangel! It looks like this is your first PR to kubeedge/kubeedge 🎉

@kubeedge-bot kubeedge-bot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2020
@kevin-wangzefeng
Copy link
Member

/approve
/assign @fisherxu

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, please see the comments :) @XJangel

cloud/pkg/cloudhub/servers/httpserver/server.go Outdated Show resolved Hide resolved
edge/pkg/edgehub/process.go Outdated Show resolved Hide resolved
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2020
@fisherxu
Copy link
Member

fisherxu commented May 7, 2020

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@fisherxu fisherxu closed this May 7, 2020
@fisherxu fisherxu reopened this May 7, 2020
@kubeedge-bot kubeedge-bot merged commit 0c9eaee into kubeedge:master May 7, 2020
kubeedge-bot added a commit that referenced this pull request May 15, 2020
…-upstream-release-1.3

Automated cherry pick of #1640: change the token separator space to dot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants