Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use net.JoinHostPort to assemble URL #1683

Merged
merged 1 commit into from
May 16, 2020
Merged

use net.JoinHostPort to assemble URL #1683

merged 1 commit into from
May 16, 2020

Conversation

YaozhongZhang
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind feature

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kubeedge-bot
Copy link
Collaborator

Welcome @YaozhongZhang! It looks like this is your first PR to kubeedge/kubeedge 🎉

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 15, 2020
@kadisi
Copy link
Member

kadisi commented May 15, 2020

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
@fisherxu
Copy link
Member

/lgtm
Would you like add your eamil that used in the commit to your github profile? Since now the github can't identify and count your contribution. @YaozhongZhang
image

@daixiang0
Copy link
Member

@YaozhongZhang hi, there are more than one place use ": port" , would you like to find and optimize all of them in this pr?

@YaozhongZhang
Copy link
Author

/lgtm
Would you like add your eamil that used in the commit to your github profile? Since now the github can't identify and count your contribution. @YaozhongZhang
image

@fisherxu Done, thanks.

@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2020
@YaozhongZhang
Copy link
Author

@YaozhongZhang hi, there are more than one place use ": port" , would you like to find and optimize all of them in this pr?

@daixiang0 /PTAL

@daixiang0
Copy link
Member

daixiang0 commented May 15, 2020 •
edited
Loading

Looks good to me.

@kubeedge-bot
Copy link
Collaborator

@daixiang0: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadisi
Copy link
Member

kadisi commented May 15, 2020 •
edited
Loading

@YaozhongZhang please squash your commit

then lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
@kadisi kadisi removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
@YaozhongZhang YaozhongZhang force-pushed the joinHostPort branch 2 times, most recently from 3c0ec03 to a5498d9 Compare May 15, 2020 14:01
@fisherxu
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
@kadisi
Copy link
Member

kadisi commented May 15, 2020

/approve

kevin-wangzefeng
kevin-wangzefeng reviewed May 16, 2020
View reviewed changes
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadisi, kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2020
@kubeedge-bot kubeedge-bot merged commit a2f1644 into kubeedge:master May 16, 2020
@YaozhongZhang YaozhongZhang deleted the joinHostPort branch July 8, 2020 10:50
@YaozhongZhang YaozhongZhang mentioned this pull request Aug 24, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@fisherxu fisherxu Awaiting requested review from fisherxu

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@YaozhongZhang @kubeedge-bot @kadisi @fisherxu @daixiang0 @kevin-wangzefeng