Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metrics-server in cloud #1735

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Conversation

Poor12
Copy link
Contributor

@Poor12 Poor12 commented May 27, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind feature

/kind feature

What this PR does / why we need it:
By multiplexing the cloudstream and edgestream tunnels, the /stats/summary on the edge can be exposed to the metrics-server on the cloud. By setting --kubelet-port = 10350, metrics-server can capture the monitoring data of the edge node.

Which issue(s) this PR fixes:
Fixes #1561

Special notes for your reviewer:
The metrics-server 0.3.x is not yet compatible with kubeedge. If you need to use this feature urgently, you can download the metrics-sever source code and remake the image through the "make container" command. By using the flag --kubelet-use-node-status-port and hostNetwork: true, metrics-server can run normally on kubeedge,ref https://github.com/kubernetes-sigs/metrics-server.

The most important point is that the cloudstream and edgestream modules must be turned on.

image

image

Now cloud can use the /stats,/stats/summary,/stats/containerAPI to access the edge monitoring information.

@kubeedge-bot kubeedge-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels May 27, 2020
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2020
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 28, 2020
@Poor12
Copy link
Contributor Author

Poor12 commented Jun 1, 2020

/CC @kadisi

@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2020
@Poor12 Poor12 force-pushed the test branch 2 times, most recently from a7933a0 to d3c9356 Compare June 4, 2020 15:32
@Poor12 Poor12 changed the title [WIP]:Expose summaryAPI on edge to metrics-server Expose summaryAPI on edge to metrics-server Jun 5, 2020
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2020
@Poor12 Poor12 changed the title Expose summaryAPI on edge to metrics-server Support metrics-server in cloud Jun 11, 2020
@kadisi
Copy link
Member

kadisi commented Jun 22, 2020

/lgtm

thanks @Poor12

please add release notes

@kadisi kadisi added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@Poor12
Copy link
Contributor Author

Poor12 commented Jun 22, 2020

Added release-note.

@fisherxu
Copy link
Member

fisherxu commented Jul 1, 2020

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@fisherxu
Copy link
Member

fisherxu commented Jul 1, 2020

@Poor12 Thanks :)

@kubeedge-bot kubeedge-bot merged commit 707e5a6 into kubeedge:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics at edge
4 participants