-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add containerLogsDir to store legacy symbolic #1886
Conversation
/lgtm |
// If the container logs directory does not exist, create it. | ||
if _, err := os.Stat(ContainerLogsDir); err != nil { | ||
if err := e.os.MkdirAll(ContainerLogsDir, 0755); err != nil { | ||
klog.Errorf("Failed to create directory %q: %v", ContainerLogsDir, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here %s is enough, see https://gobyexample.com/string-formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err is not string here, why use %s? I think %v is consistent with k8s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean no need to use %q.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the only difference is whether the output contains double quotes.k8s use %q, I think keeping the same is no problem.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes #1883
Special notes for your reviewer: