Refine the error messages in devicetwin/dttype #1952
Conversation
kubeedge-bot
added
the
kind/cleanup
kubeedge-bot
added
the
size/XS
|
lgtm, would you like to squash the commits? |
kubeedge-bot
added
size/M
|
Better to use a more meaningful title. |
Yes, I just new a branch named oneword and push the change. Not clear why it's used by the pull request message. |
|
@sailorvii please squash the commits |
edge/pkg/devicetwin/dttype/types.go
Outdated
| ErrorUnmarshalInfo = "Unmarshal update request body failed, please check the request" | ||
| ErrorUpdateInfo = "Update twin error, key:twin does not exist" | ||
| ErrorKeyInfo = "The key of twin must only include upper or lowercase letters, number, english, and special letter - _ . , : / @ # and the length of key should be less than 128 bytes" | ||
| ErrorValueInfo = "The value of twin must only include upper or lowercase letters, number, english, and special letter - _ . , : / @ # and the length of value should be less than 512 bytes" |
There was a problem hiding this comment.
Suggest using errors. Errorf () or errors.New()
There was a problem hiding this comment.
Thanks for your comments.
Done.
Signed-off-by: sailorvii <challengingway@hotmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE