Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudhub: put all module name and module group in one place #2033

Merged
merged 1 commit into from
Sep 10, 2020
Merged

cloudhub: put all module name and module group in one place #2033

merged 1 commit into from
Sep 10, 2020

Conversation

YaozhongZhang
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind feature

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kubeedge-bot kubeedge-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 5, 2020
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 5, 2020
daixiang0
daixiang0 suggested changes Aug 5, 2020
View reviewed changes
cloud/pkg/cloudhub/constants/service.go Outdated

const (
CloudHubModuleName = "cloudhub"
CloudHubModuleGroup = "cloudhub"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think put all module name and module group constant in one place is better.

@kubeedge-bot
Copy link
Collaborator

@daixiang0: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YaozhongZhang YaozhongZhang mentioned this pull request Aug 24, 2020
Closed
6 tasks
@fisherxu
Copy link
Member

It's better to write them in one place

@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2020
@YaozhongZhang YaozhongZhang changed the title set cloudhub module name and group to constants cloudhub: put all module name and module group in one place Aug 24, 2020
@YaozhongZhang
Copy link
Author

@daixiang0 @fisherxu Done. PTAL.

daixiang0
daixiang0 reviewed Aug 24, 2020
View reviewed changes
cloud/pkg/cloudhub/cloudhub.go Outdated
@@ -1,6 +1,7 @@
package cloudhub

import (
"github.com/kubeedge/kubeedge/cloud/pkg/common/modules"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call goimport -w -local "github.com/kubeedge/kubeedge" to sort.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. thx.

@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2020
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2020
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2020
@YaozhongZhang YaozhongZhang reopened this Aug 25, 2020
@fisherxu
Copy link
Member

fisherxu commented Sep 9, 2020

lgtm, please rebase the conflicting files

@fisherxu
Copy link
Member

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@kubeedge-bot kubeedge-bot merged commit 0fafd11 into kubeedge:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daixiang0 daixiang0 daixiang0 requested changes

@fisherxu fisherxu Awaiting requested review from fisherxu

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaozhongZhang @kubeedge-bot @fisherxu @daixiang0