Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keadm: use blang/semver to compare versions #2086

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

YaozhongZhang
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind feature

/kind bug

What this PR does / why we need it:
use blang/semver to compare versions

Which issue(s) this PR fixes:

Fixes #2085

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 18, 2020
@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 18, 2020
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please sorts the imports:

golang lib

github lib

kubeedge lib

@YaozhongZhang
Copy link
Author

LGTM, please sorts the imports:

golang lib

github lib

kubeedge lib

@fisherxu done. thx.

@fisherxu
Copy link
Member

CI seems failed :)

@YaozhongZhang
Copy link
Author

CI seems failed :)

some white noise, already cleaned up.

@fisherxu fisherxu closed this Aug 25, 2020
@fisherxu fisherxu reopened this Aug 25, 2020
@fisherxu
Copy link
Member

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
@kubeedge-bot kubeedge-bot merged commit 01d49fe into kubeedge:master Aug 25, 2020
@YaozhongZhang YaozhongZhang deleted the semver branch August 27, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparing version numbers as strings could be wrong in some cases.
3 participants