edgehub dispatch message by type #2116
Conversation
kubeedge-bot
added
the
size/M
lvchenggang
force-pushed
the
edgehub_update
branch
from
604f2de
to
2f470b2
Compare
edge/pkg/edgehub/process.go
Outdated
| md = modules.BusGroup | ||
| default: | ||
| klog.Warningf("msg_group: %s not found", group) | ||
| return fmt.Errorf("msg_group: %s not found", group) |
There was a problem hiding this comment.
What's the difference of these two implementation?
There was a problem hiding this comment.
Maybe the groupMap can be deleted?
There was a problem hiding this comment.
Use switch-case looks more intuitive, the groupMap structure still used in edgehub currently.
|
Looks like there's something wrong with the CI/UT |
Yes, I will look at this question. |
lvchenggang
force-pushed
the
edgehub_update
branch
from
2f470b2
to
935121a
Compare
lvchenggang
force-pushed
the
edgehub_update
branch
from
935121a
to
4ac2f21
Compare
kubeedge-bot
added
size/S
The UT problem has been resolved. |
How does the utility be fixed? Looks like has no modification ;-) |
The UT error is caused by the following changes: Finally, I reducing these changes and everything is OK |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Like the previous way, through array to dispatch message in edgehub is not intuitive, by switch-case grammar will be clearer and maintainable.
Does this PR introduce a user-facing change?:
NONE