Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the function of unsubscribe topics #2188

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Add the function of unsubscribe topics #2188

merged 3 commits into from
Oct 31, 2020

Conversation

muxuelan
Copy link
Member

What type of PR is this?
kind feature

What this PR does / why we need it:
Added the function of unsubscribe topics. Eventbus is the client of mqtt, this commit can help to unsubscribe some topics it has subscribed. And this commit realized two types, including both the internal mqtt broker and the external mqtt broker.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot
Copy link
Collaborator

Welcome @muxuelan! It looks like this is your first PR to kubeedge/kubeedge 🎉

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2020
@daixiang0
Copy link
Member

@muxuelan thanks for your contribution, please add tests for them.

@chendave
Copy link
Member

/kind feature

@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 24, 2020
Copy link
Member

@chendave chendave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we miss the UT totally for those packages.

@fisherxu
Copy link
Member

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2020
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2020
@kubeedge-bot kubeedge-bot merged commit 8280082 into kubeedge:master Oct 31, 2020
@muxuelan muxuelan changed the title Added the function of unsubscribe topics Add the function of unsubscribe topics Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants