-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the function of unsubscribe topics #2188
Conversation
Welcome @muxuelan! It looks like this is your first PR to kubeedge/kubeedge 🎉 |
@muxuelan thanks for your contribution, please add tests for them. |
/kind feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like we miss the UT totally for those packages.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
kind feature
What this PR does / why we need it:
Added the function of unsubscribe topics. Eventbus is the client of mqtt, this commit can help to unsubscribe some topics it has subscribed. And this commit realized two types, including both the internal mqtt broker and the external mqtt broker.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: