fix err information of certutil #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
the
kind/feature
kubeedge-bot
added
the
size/XS
fisherxu
reviewed
Nov 18, 2020
Comment on lines
103
to
105
| fmt.Println("must specify a CommonName") | ||
| err :=errors.New("must specify a CommonName") | ||
| return nil, err |
There was a problem hiding this comment.
Suggested change
| fmt.Println("must specify a CommonName") | |
| err :=errors.New("must specify a CommonName") | |
| return nil, err | |
| return nil, errors.New("must specify a CommonName") |
There was a problem hiding this comment.
fmt print can be deleted here.
Comment on lines
108
to
110
| fmt.Println("must specify at least one ExtKeyUsage") | ||
| err :=errors.New("must specify at least one ExtKeyUsage") | ||
| return nil, err |
There was a problem hiding this comment.
Suggested change
| fmt.Println("must specify at least one ExtKeyUsage") | |
| err :=errors.New("must specify at least one ExtKeyUsage") | |
| return nil, err | |
| return nil, errors.New("must specify at least one ExtKeyUsage") |
fisherxu
reviewed
Nov 18, 2020
Comment on lines
103
to
105
| fmt.Println("must specify a CommonName") | ||
| err :=errors.New("must specify a CommonName") | ||
| return nil, err |
There was a problem hiding this comment.
fmt print can be deleted here.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
/lgtm |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
If not add the modify, err equals nil here, and this will affect the generation of certificate.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: