Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge/pkg/edgehub: fix grammar issues #2343

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

lvchenggang
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
Some methods of edgehub have grammar mistake, fix them to camelCased.

Does this PR introduce a user-facing change?:
NONE

@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2020
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 18, 2020
@daixiang0
Copy link
Member

Are there all grammar issues for edgehub part? Please put them together in this pr then let me know.

Also, better title as "edge/pkg/edgehub: fix grammar issues".

@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2020
@lvchenggang lvchenggang changed the title fix methods name of edgehub edge/pkg/edgehub: fix grammar issues Nov 19, 2020
@lvchenggang
Copy link
Member Author

Are there all grammar issues for edgehub part? Please put them together in this pr then let me know.

Also, better title as "edge/pkg/edgehub: fix grammar issues".

OK, related changes have been updated

@lvchenggang lvchenggang force-pushed the fix_grammar_mistakes branch 4 times, most recently from b2d891e to 2ca6199 Compare November 20, 2020 02:23
@fisherxu
Copy link
Member

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@kubeedge-bot kubeedge-bot merged commit 47e6e29 into kubeedge:master Nov 23, 2020
@lvchenggang lvchenggang deleted the fix_grammar_mistakes branch November 27, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants