fix msg in nodestore compare error #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
kind/bug
|
Make sense, thanks, we can also pick it to release-1.5 @threestoneliu |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
done! 2394 |
kubeedge-bot
added a commit
that referenced
this pull request
Dec 4, 2020
…#2387-upstream-release-1.5 Automated cherry pick of #2387: fix msg in nodestore compare error
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The managePod method in synccontroller will check pod is exist in kuberntes, if pod not found ,synccontroller will send a delete operation message to cloudhub, but the message's resourceversion is empty. then channelq will overwrite the message that stored in nodestore . next time if trigger synccontroller.CompareResourceVersion will cause the cloudcore panic. So we can check wheather the message in node store is a delete operation message to avoid this panic.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: