Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the invalid memory address panic of common_test in eventbus #2396

Merged
merged 1 commit into from
Dec 4, 2020
Merged

fix the invalid memory address panic of common_test in eventbus #2396

merged 1 commit into from
Dec 4, 2020

Conversation

muxuelan
Copy link
Member

@muxuelan muxuelan commented Dec 3, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
The func TestHubClientInit and TestLoopConnect under "kubeedge/edge/pkg/eventbus/common/util/common_test.go" build failed because of "invalid memory address or nil pointer dereference", so I add the init().
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 3, 2020
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2020
@muxuelan muxuelan changed the title Eventbus common fix the invalid memory address panic of common_test in eventbus Dec 3, 2020
@fisherxu
Copy link
Member

fisherxu commented Dec 4, 2020

Has any error logs?

@muxuelan
Copy link
Member Author

muxuelan commented Dec 4, 2020

Has any error logs?
As follows.
image

@fisherxu
Copy link
Member

fisherxu commented Dec 4, 2020

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@kubeedge-bot kubeedge-bot merged commit 742c88a into kubeedge:master Dec 4, 2020
@muxuelan muxuelan deleted the eventbusCommon branch December 21, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants