-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keadm: clean useless file after keadm_e2e test #2468
keadm: clean useless file after keadm_e2e test #2468
Conversation
@@ -398,7 +398,7 @@ func killKubeEdgeBinary(proc string) error { | |||
|
|||
//isKubeEdgeProcessRunning checks if the given process is running or not | |||
func isKubeEdgeProcessRunning(proc string) (bool, error) { | |||
procRunning := fmt.Sprintf("pidof %s 2&>1", proc) | |||
procRunning := fmt.Sprintf("pidof %s 2>&1", proc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like 2>&1
is right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my mistake.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
2>&1
to redirect stderr to stdout.Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: