Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keadm: clean useless file after keadm_e2e test #2468

Merged
merged 1 commit into from
Dec 28, 2020
Merged

keadm: clean useless file after keadm_e2e test #2468

merged 1 commit into from
Dec 28, 2020

Conversation

yf4n
Copy link
Member

@yf4n yf4n commented Dec 27, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. remove keadm.test and config.json before keadm_e2e.sh exit. keep directory clean.
  2. should use 2>&1 to redirect stderr to stdout.

Which issue(s) this PR fixes:

NONE

Does this PR introduce a user-facing change?:

NONE

@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 27, 2020
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 27, 2020
@@ -398,7 +398,7 @@ func killKubeEdgeBinary(proc string) error {

//isKubeEdgeProcessRunning checks if the given process is running or not
func isKubeEdgeProcessRunning(proc string) (bool, error) {
procRunning := fmt.Sprintf("pidof %s 2&>1", proc)
procRunning := fmt.Sprintf("pidof %s 2>&1", proc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 2>&1 is right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my mistake.

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2020
@fisherxu
Copy link
Member

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2020
@kubeedge-bot kubeedge-bot merged commit 5d41696 into kubeedge:master Dec 28, 2020
@yf4n yf4n deleted the clean-useless-file-after-keadm_e2e-test branch December 30, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants