Fix some minor errors #2937
Merged
Fix some minor errors #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
the
size/S
fisherxu
reviewed
Jun 30, 2021
| @@ -285,7 +285,7 @@ func CheckNetWork(IP string, timeout int, cloudhubServer string, edgecoreServer | |||
| if config != "" { | |||
| edgeConfig, err := util.ParseEdgecoreConfig(config) | |||
| if err != nil { | |||
| err = fmt.Errorf("parse Edgecore config failed") | |||
| return fmt.Errorf("parse Edgecore config failed") | |||
| } else { | |||
There was a problem hiding this comment.
You can delete the else here.
if err != nil {
return fmt.Errorf("parse Edgecore config failed")
}
if cloudhubServer == "" {
cloudhubServer = edgeConfig.Modules.EdgeHub.WebSocket.Server
......
There was a problem hiding this comment.
Sorry，I thought you ask me delete whole else part. Get it now.
There was a problem hiding this comment.
the extra spaces have been cleaered
xujingjing-cmss
force-pushed
the
dev
branch
2 times, most recently
from
a9842d9
to
4e17231
Compare
Signed-off-by: xujingjing <xujingjing_yewu@cmss.chinamobile.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xujingjing xujingjing_yewu@cmss.chinamobile.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
some of the errors was not handled correctly.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: