Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some code smells #3148

Merged
merged 1 commit into from
Sep 11, 2021
Merged

fix some code smells #3148

merged 1 commit into from
Sep 11, 2021

Conversation

WillardHu
Copy link
Collaborator

  • upstream.go error strings should not be capitalized
  • util_test.go avoid using reflect.DeepEqual with errors

Signed-off-by: WillardHu wei.hu@daocloud.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 8, 2021
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2021
@subpathdev
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@subpathdev
Copy link
Member

can you fix the unit test, please

@gy95
Copy link
Member

gy95 commented Sep 8, 2021

seems not a right way to use errors.Is to judge error is equal or not.

@WillardHu
error strings should not be capitalized
d5197d5 
Signed-off-by: WillardHu <wei.hu@daocloud.io>
@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@WillardHu
Copy link
Collaborator Author

can you fix the unit test, please

OK

@WillardHu
Copy link
Collaborator Author

seems not a right way to use errors.Is to judge error is equal or not.

Yes, you're right

fisherxu
fisherxu reviewed Sep 11, 2021
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2021
@zc2638
Copy link
Member

zc2638 commented Sep 11, 2021

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2021
@kubeedge-bot kubeedge-bot merged commit 6cd4853 into kubeedge:master Sep 11, 2021
@WillardHu WillardHu deleted the fix/code-smells branch September 15, 2021 10:30
@WillardHu WillardHu mentioned this pull request Oct 12, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@kadisi kadisi Awaiting requested review from kadisi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@WillardHu @subpathdev @gy95 @kubeedge-bot @zc2638 @fisherxu