fix: use path.Join replace fmt.Sprintf to set the path value
#3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: WillardHu <wei.hu@daocloud.io>
kubeedge-bot
added
the
size/M
chendave
reviewed
Sep 10, 2021
| @@ -60,20 +61,20 @@ func (factory *eventbusFactory) GetSource(ep *v1.RuleEndpoint, sourceResource ma | |||
| } | |||
|
|
|||
| func (eb *EventBus) RegisterListener(handle listener.Handle) error { | |||
| listener.MessageHandlerInstance.AddListener(fmt.Sprintf("%s/node/%s/%s/%s", "bus", eb.nodeName, eb.namespace, eb.subTopic), handle) | |||
| listener.MessageHandlerInstance.AddListener(path.Join("bus/node", eb.nodeName, eb.namespace, eb.subTopic), handle) | |||
There was a problem hiding this comment.
can you pls share some data on how the performance got improved?
There was a problem hiding this comment.
var s1t time.Time
var used time.Duration
s1t = time.Now()
for i := 0; i < 100000; i++ {
fmt.Sprintf("node/%s/%s/%s", "nodeName", "namespace", "subTopic")
}
used = time.Since(s1t)
fmt.Println("time cost of `sprintf`:", used)
s1t = time.Now()
for i := 0; i < 100000; i++ {
path.Join("node", "nodeName", "namespace", "subTopic")
}
used = time.Since(s1t)
fmt.Println("time cost of `join`:", used)Run 3 times pirnt out:
=== RUN TestPathJoin
time cost of `sprintf`: 15.840042ms
time cost of `join`: 12.771455ms
--- PASS: TestPathJoin (0.03s)
=== RUN TestPathJoin
time cost of `sprintf`: 14.852592ms
time cost of `join`: 12.130716ms
--- PASS: TestPathJoin (0.03s)
=== RUN TestPathJoin
time cost of `sprintf`: 19.307545ms
time cost of `join`: 14.843423ms
--- PASS: TestPathJoin (0.03s)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: WillardHu wei.hu@daocloud.io
What type of PR is this?
/kind bug
What this PR does / why we need it:
Better performance and readability
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: