-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix assign grammar of application agent #3333
Conversation
f6c2cb9
to
3393dbf
Compare
/LGTM |
@gy95: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9b36c6b
to
8189dcd
Compare
@@ -270,7 +270,7 @@ var once sync.Once | |||
|
|||
// edged config.Config.HostnameOverride | |||
func NewApplicationAgent() *Agent { | |||
defaultAgent := &Agent{nodeName: metaserverconfig.Config.NodeName} | |||
defaultAgent = &Agent{nodeName: metaserverconfig.Config.NodeName} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we can delete the global variable, and keep the local variable here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay~ I have delete the global variable instead.
8189dcd
to
54c5536
Compare
var once sync.Once According to the |
@zc2638 Should we just change the part of
to the flowing code, and delete the declare "var once sync.Once".
|
@jidalong |
Signed-off-by: jidalong <jidalong@cmss.chinamobile.com>
54c5536
to
64416c5
Compare
Okey, I think it would be better as well~and has change it. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Since variable "defaultAgent" was assigned by ":=" in line 273, so we should delete the declared line 268.
Does this PR introduce a user-facing change?:
NONE