fix "keadm get nodes -A" printing namespaces while nodes without namespaces actually #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
the
size/XS
jidalong
force-pushed
the
kubeadmnode
branch
from
100bdba
to
9e58830
Compare
jidalong
changed the title
Signed-off-by: jidalong <jidalong@cmss.chinamobile.com>
jidalong
force-pushed
the
kubeadmnode
branch
from
9e58830
to
a47fed8
Compare
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
/lgtm |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When excute “keadm get nodes/node -A/--all-namespaces ”，keadm may not print the namespace with null while in original k8s，the resource of node does not have any namespaces.
before:
after this PR, not print NAMESPACE column anymore:
Which issue(s) this PR fixes:
Fixes #3345
Does this PR introduce a user-facing change?:
NONE