add metric for cloudcore monitoring #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
requested review from
chendave,
kadisi,
kevin-wangzefeng and
TianTianBigWang
kubeedge-bot
added
the
size/L
gy95
reviewed
Mar 7, 2022
pkg/apis/componentconfig/cloudcore/v1alpha1/validation/validation.go
Outdated
Show resolved
Hide resolved
7 tasks
fisherxu
reviewed
Mar 15, 2022
|
/cc @zhu733756 |
zhu733756
reviewed
Mar 16, 2022
kubeedge-bot
added
the
needs-rebase
kubeedge-bot
removed
the
needs-rebase
wackxu
force-pushed
the
addmetric
branch
3 times, most recently
from
48f3ba8
to
18d77eb
Compare
|
/cc @zhu733756 @fisherxu |
zhu733756
reviewed
May 17, 2022
|
Totally LGTM. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
kubeedge-bot
added
the
needs-rebase
kubeedge-bot
removed
the
needs-rebase
wackxu
force-pushed
the
addmetric
branch
4 times, most recently
from
3bbee32
to
6c88d6c
Compare
|
sorry for the delay, all the comments are resolved, PTAL @zhu733756 @fisherxu |
zhu733756
reviewed
Nov 1, 2022
Signed-off-by: wackxu <xushiwei5@huawei.com>
|
LGTM |
|
/assign @vincentgoat @fisherxu |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
add metric for cloudcore monitoring
Special notes for your reviewer:
Does this PR introduce a user-facing change?: