Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom image repo for keadm join beta #3654

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

TianTianBigWang
Copy link
Member

Signed-off-by: TianTianBigWang zilong.wang@daocloud.io

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2022
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2022
pkg/image/image.go Outdated Show resolved Hide resolved
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2022
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also needed for init?

@TianTianBigWang
Copy link
Member Author

Is this also needed for init?

It looks like image and tag are used in init-beta.go, I can use a custom image repository for init-beta in another pr if needed

@TianTianBigWang TianTianBigWang force-pushed the feat/join-img-repo branch 2 times, most recently from 32afb39 to a4c251e Compare March 14, 2022 06:37
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2022
Signed-off-by: TianTianBigWang <zilong.wang@daocloud.io>
@zc2638
Copy link
Member

zc2638 commented Mar 14, 2022

/lgtm
/assign @fisherxu

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2022
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@kubeedge-bot kubeedge-bot merged commit f4fa673 into kubeedge:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants