Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keadm: beta join support remote runtime #3655

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

zc2638
Copy link
Member

@zc2638 zc2638 commented Mar 9, 2022

Signed-off-by: zc zc2638@qq.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

k8s v1.24 has abandoned dockershim and fully embraces CRI, such as containerd and cri-o.
So we need to support CRI to execute commands better.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

We can use the remote method with the following command.

keadm beta join --cloudcore-ipport <cloud-address> --runtimetype remote --remote-runtime-endpoint unix:///run/containerd/containerd.sock --kubeedge-version=v1.10.0

Does this PR introduce a user-facing change?:


Signed-off-by: zc <zc2638@qq.com>
@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2022
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2022
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen too much fixing, it should be fine before...

Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@kubeedge-bot kubeedge-bot merged commit 328ee5c into kubeedge:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants