-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keadm beta e2e #3699
Add Keadm beta e2e #3699
Conversation
814f0e5
to
9460fb3
Compare
Need to rebase #3692 |
tests/e2e/scripts/keadm_e2e.sh
Outdated
@@ -87,6 +87,7 @@ END | |||
while true; do | |||
sleep 3 | |||
kubectl get node | grep edge-node | grep -q Ready && break | |||
echo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can rebase it now :)
0edd4af
to
2bf7df0
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @zc2638
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhu733756 <zhu733756@kubesphere.io> Signed-off-by: zhu733756 <qq1079333812@gmail.com>
2bf7df0
to
ddd643b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
Converting the former helm keadm e2e script to keadm beta e2e script since we have supported the keadm beta commands.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: