Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keadm beta e2e #3699

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Add Keadm beta e2e #3699

merged 1 commit into from
Mar 24, 2022

Conversation

zhu733756
Copy link
Member

@zhu733756 zhu733756 commented Mar 14, 2022

What type of PR is this?

Converting the former helm keadm e2e script to keadm beta e2e script since we have supported the keadm beta commands.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2022
@zhu733756 zhu733756 force-pushed the keadm-beta-e2e branch 7 times, most recently from 814f0e5 to 9460fb3 Compare March 14, 2022 11:20
@zhu733756
Copy link
Member Author

Need to rebase #3692

@@ -87,6 +87,7 @@ END
while true; do
sleep 3
kubectl get node | grep edge-node | grep -q Ready && break
echo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can rebase it now :)

@zhu733756 zhu733756 force-pushed the keadm-beta-e2e branch 5 times, most recently from 0edd4af to 2bf7df0 Compare March 18, 2022 07:53
@zhu733756
Copy link
Member Author

We can rebase it now :)

Done.

Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @zc2638

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
Signed-off-by: zhu733756 <zhu733756@kubesphere.io>
Signed-off-by: zhu733756 <qq1079333812@gmail.com>
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@kubeedge-bot kubeedge-bot merged commit 94acf10 into kubeedge:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants