keadm beta config images: support remote runtime #3700
Conversation
kubeedge-bot
added
the
size/M
| "Container runtime type, default is docker") | ||
|
|
||
| cmd.Flags().StringVar(&cfg.RemoteRuntimeEndpoint, cmdcommon.RemoteRuntimeEndpoint, cfg.RemoteRuntimeEndpoint, | ||
| "KubeEdge Edge Node RemoteRuntimeEndpoint string") |
There was a problem hiding this comment.
s/KubeEdge Edge Node RemoteRuntimeEndpoint string/remoteRuntimeEndpoint is the endpoint of remote runtime service in edge node/g
There was a problem hiding this comment.
fixed to The endpoint of remote runtime service in edge node
| "Container runtime type, default is docker") | ||
|
|
||
| cmd.Flags().StringVar(&cfg.RemoteRuntimeEndpoint, cmdcommon.RemoteRuntimeEndpoint, cfg.RemoteRuntimeEndpoint, | ||
| "KubeEdge Edge Node RemoteRuntimeEndpoint string") |
There was a problem hiding this comment.
s/KubeEdge Edge Node RemoteRuntimeEndpoint string/remoteRuntimeEndpoint is the endpoint of remote runtime service in edge node/g
| } | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
if image not exist, we should return err
There was a problem hiding this comment.
line 275: this status == nil || status.Id == "" block represent the image not exist
line 281 represent the image exist or pull image successfully.
| func (runtime *DockerRuntime) PullImage(image string) error { | ||
| cli, err := dockerclient.NewClientWithOpts(dockerclient.FromEnv) | ||
| if err != nil { | ||
| return fmt.Errorf("init docker dockerclient failed: %v", err) |
There was a problem hiding this comment.
s/init docker dockerclient failed/init docker client failed/g
| if err != nil { | ||
| return fmt.Errorf("init docker client failed: %v", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we should call docker NegotiateAPIVersion to solve docker client and server API version mismatch problem. I have encountered this problem ever
|
@wackxu: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
kubeedge-bot
added
needs-rebase
Signed-off-by: gy95 <guoyao17@huawei.com>
Signed-off-by: gy95 <guoyao17@huawei.com>
Signed-off-by: gy95 <guoyao17@huawei.com>
kubeedge-bot
removed
the
needs-rebase
Signed-off-by: gy95 <guoyao17@huawei.com>
Signed-off-by: gy95 <guoyao17@huawei.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu, wackxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
/lgtm |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: