Use armhf as default for armv7/v6 #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
the
kind/cleanup
kubeedge-bot
added
the
size/XS
|
Is this also need fixing? |
Signed-off-by: fisherxu <xufei40@huawei.com>
Done, though it still haven't used |
|
lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chendave The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
/lgtm |
This was referenced Mar 22, 2022
kubeedge-bot
added a commit
that referenced
this pull request
Mar 22, 2022
…-upstream-release-1.9 Automated cherry pick of #3723: support armhf
kubeedge-bot
added a commit
that referenced
this pull request
Mar 22, 2022
…-upstream-release-1.10 Automated cherry pick of #3723: support armhf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fisherxu xufei40@huawei.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Now for the armv6 and later, all support armhf, and for ubuntu since 12.04, armel will not supported.
When cross-building, arm-linux-gnueabi-gcc will build armel by default, arm-linux-gnueabihf-gcc will build armhf by default.
And armhf has better compatibility. Armv5 or before I think it will be probably rarely used?
Ref: #3586 (comment)
https://github.com/golang/go/wiki/GoArm#supported-architectures
https://github.com/golang/go/wiki/GoArm#supported-operating-systems
cc @zhu733756 @dafanshu
Which issue(s) this PR fixes:
Fixes ##3586 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?: