Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move keadm beta command to GA #3900

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Conversation

gy95
Copy link
Member

@gy95 gy95 commented Jun 6, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #3879

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 6, 2022
gy95 added 2 commits June 9, 2022 09:17
Signed-off-by: gy95 <guoyao17@huawei.com>
Signed-off-by: gy95 <guoyao17@huawei.com>
@gy95 gy95 closed this Jun 9, 2022
@gy95 gy95 reopened this Jun 9, 2022
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good :)

cmd.AddCommand(NewManifestGenerateBeta())
cmd.AddCommand(newCmdConfig())
cmd.AddCommand(NewKubeEdgeResetBeta())

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remain the beta sub-cmd here, in future we can add other beta cmd here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted, please review again

Signed-off-by: gy95 <guoyao17@huawei.com>
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2022
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@kubeedge-bot kubeedge-bot merged commit 8b04a6a into kubeedge:master Jun 14, 2022
@gy95 gy95 deleted the keadm_beta_ga branch June 14, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants