add generic informer #4375
Merged
add generic informer #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
the
kind/feature
kubeedge-bot
added
the
size/L
wackxu
force-pushed
the
informerone
branch
3 times, most recently
from
d4ffde9
to
3648a14
Compare
|
/assign @vincentgoat @gy95 @fisherxu @Shelley-BaoYue |
|
/lgtm |
gy95
reviewed
Nov 10, 2022
gy95
approved these changes
Nov 10, 2022
gy95
reviewed
Nov 10, 2022
kubeedge-bot
added
the
needs-rebase
kubeedge-bot
removed
the
needs-rebase
wackxu
force-pushed
the
informerone
branch
2 times, most recently
from
fcd5097
to
7a8c764
Compare
kubeedge-bot
removed
the
size/L
kubeedge-bot
added
the
size/XL
Signed-off-by: wackxu <xushiwei5@huawei.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu, gy95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wackxu xushiwei5@huawei.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
For now, we use dynamic informer in the dynamic controller and use built-in informer in the edgecontroller, So If user use the list-watch and enable dynamic controller, there will be two informer and for mainly used k8s built-in resources, there maybe two informers for one resources and it will increase the memory usage for cloudcore, especially in large scale scenarios.
And also in the synccontroller, we have a period sync for objectsync, and for every objectsync, we need access the kube-apiserver to make sure the resource exists or not, and this increase the burden of kube-apiserver, so we change to get the resource from the informer cache to reduce the call to the apiserver
Special notes for your reviewer:
Does this PR introduce a user-facing change?: