Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto adjust cloudcore config #4376

Merged
merged 1 commit into from
Jan 16, 2023
Merged

auto adjust cloudcore config #4376

merged 1 commit into from
Jan 16, 2023

Conversation

wackxu
Copy link
Collaborator

@wackxu wackxu commented Nov 4, 2022 •
edited

Signed-off-by: wackxu xushiwei5@huawei.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

implementation of #4553

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NodeLimit is a maximum number of edge node that can connect to the single CloudCore instance. You should take this parameter seriously, because this parameter is closely related to the number of goroutines for message processing.
The edgecontroller config will be auto adjust according to the nodeLimit config

@kubeedge-bot kubeedge-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 4, 2022
@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2022
gy95
gy95 reviewed Nov 4, 2022
View reviewed changes
common/constants/default.go Outdated Show resolved Hide resolved
cloud/cmd/cloudcore/app/server.go Show resolved Hide resolved
@wackxu
Copy link
Collaborator Author

wackxu commented Nov 4, 2022

/hold

@kubeedge-bot kubeedge-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2022
@stale
Copy link

stale bot commented Jan 5, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale label Jan 5, 2023
@wackxu wackxu added this to the v1.13 milestone Jan 9, 2023
@stale stale bot removed the lifecycle/stale label Jan 9, 2023
@wackxu
auto adjust cloudcore config
134f17b 
Signed-off-by: wackxu <xushiwei5@huawei.com>
@gy95
Copy link
Member

gy95 commented Jan 14, 2023

link the proposal :)

@wackxu
Copy link
Collaborator Author

wackxu commented Jan 14, 2023

/hold cancel

@kubeedge-bot kubeedge-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2023
@vincentgoat
Copy link
Member

Is there any metrics data to support this adjustment?

@wackxu
Copy link
Collaborator Author

wackxu commented Jan 14, 2023

Is there any metrics data to support this adjustment?

The calculation formula is based on previous large-scale test experience and We can make adjustments based on subsequent user feedback

@wackxu wackxu added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 16, 2023
fisherxu
fisherxu reviewed Jan 16, 2023
View reviewed changes
common/constants/default.go
@@ -79,26 +81,24 @@ const (
DefaultKubeNamespace = v1.NamespaceAll
DefaultKubeQPS = 100.0
DefaultKubeBurst = 200
DefaultNodeLimit = 500
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the DefaultNodeLimit to 500? If it's necessary to change, it's need to have some notification.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We calculate the number of workers according to nodeLimit，I think nodeLimit default value is too big, because there are few users with this node size

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey.

fisherxu
fisherxu reviewed Jan 16, 2023
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fisherxu
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@fisherxu
Copy link
Member

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@kubeedge-bot kubeedge-bot merged commit 2f959fd into kubeedge:master Jan 16, 2023
@wackxu wackxu deleted the adjustconfig branch January 16, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@gy95 gy95 gy95 left review comments

@subpathdev subpathdev Awaiting requested review from subpathdev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wackxu @gy95 @vincentgoat @fisherxu @kubeedge-bot