Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mosquitto image:tag can be easy replaced in future. #4406

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Make mosquitto image:tag can be easy replaced in future. #4406

merged 1 commit into from
Nov 14, 2022

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Nov 13, 2022

Signed-off-by: yanggang gang.yang@daocloud.io

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
I search the https://hub.docker.com/_/eclipse-mosquitto and https://github.com/eclipse/mosquitto/tags
now kubeedge adapt to mosquitto v1.6.15 , maybe will change in near future .
So we should change
DefaultMosquittoImage = "eclipse-mosquitto:1.6.15"
replaced work will be easy.

Signed-off-by: yanggang <gang.yang@daocloud.io>
@kubeedge-bot kubeedge-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 13, 2022
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2022
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@kubeedge-bot kubeedge-bot merged commit 4f1b627 into kubeedge:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants