Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e runner for conformance #4411

Merged
merged 6 commits into from
Jan 16, 2023
Merged

Conversation

wackxu
Copy link
Collaborator

@wackxu wackxu commented Nov 15, 2022

What type of PR is this?

/kind feature
What this PR does / why we need it:

Add e2e runner for that we can run e2e easily on user cluster

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 15, 2022

RUN mkdir -p /tmp/results

ENTRYPOINT ["e2e-runner"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a deployment sample? to illustrate e2e-runner cmd flags

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

testBinEnvKey = "TEST_BIN"
resultsDirEnvKey = "RESULTS_DIR"
kubeConfigEnvKey = "KUBECONFIG"
logFileName = "e2e.log"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this saved on the machine, but not only in container?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2022
@kubeedge-bot kubeedge-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 19, 2022
@vincentgoat vincentgoat force-pushed the adde2erunner branch 2 times, most recently from 91d219a to 1dfd0d6 Compare January 4, 2023 08:10
@kubeedge-bot kubeedge-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2023
@vincentgoat vincentgoat force-pushed the adde2erunner branch 3 times, most recently from d83a6bd to 90715d2 Compare January 5, 2023 02:43
@wackxu wackxu added this to the v1.13 milestone Jan 9, 2023
@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2023
@kubeedge-bot kubeedge-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2023
@vincentgoat vincentgoat force-pushed the adde2erunner branch 2 times, most recently from 2226d0b to 287d7a7 Compare January 16, 2023 16:12
wackxu and others added 4 commits January 17, 2023 00:32
Signed-off-by: wackxu <xushiwei5@huawei.com>
Signed-off-by: wackxu <xushiwei5@huawei.com>
Signed-off-by: vincentgoat <linguohui1@huawei.com>
Signed-off-by: vincentgoat <linguohui1@huawei.com>
Signed-off-by: vincentgoat <linguohui1@huawei.com>
Signed-off-by: vincentgoat <linguohui1@huawei.com>
@fisherxu
Copy link
Member

/lgtm

@fisherxu
Copy link
Member

/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@kubeedge-bot kubeedge-bot merged commit 53e686e into kubeedge:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants