Reused common default docker parm. #4526
Conversation
kubeedge-bot
added
the
kind/cleanup
kubeedge-bot
added
the
size/S
|
|
||
| "github.com/kubeedge/kubeedge/common/constants" |
There was a problem hiding this comment.
this should be moved to line21 and run gofmt
There was a problem hiding this comment.
thanks, i install the 'goimports plugin' , and let it format for me when 'ctrl+s'.
Had updated.
|
still ci lint err, Is the ci not works with goimports? |
| @@ -11,13 +11,13 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| "github.com/kubeedge/kubeedge/common/constants" | |||
| "github.com/kubeedge/kubeedge/keadm/cmd/keadm/app/cmd/common" | |||
| "github.com/kubeedge/kubeedge/keadm/cmd/keadm/app/cmd/util" | |||
There was a problem hiding this comment.
please format the import order
There was a problem hiding this comment.
hi, now i am use the "goimports" to save the file to keep the import order.
What is the format style is good for the ci?
There was a problem hiding this comment.
kubeedge package should be put to the last, after the third party packages. you should put the above github.com/kubeedge/* to line 21
There was a problem hiding this comment.
@gy95
thanks for explain .
so kubeage is used 'gofmt' to format the code , not 'goimport'.
Fix it
Signed-off-by: yanggang <gang.yang@daocloud.io>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
Signed-off-by: yanggang gang.yang@daocloud.io
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Reused
common/constantsdefine parm..