-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/windows nodes release #5049
Feat/windows nodes release #5049
Conversation
Signed-off-by: wujunyi <wu65830600@163.com>
Signed-off-by: wujunyi <wu65830600@163.com>
Signed-off-by: wujunyi <wu65830600@163.com>
126b6cb
to
ef4dc59
Compare
This PR seems to implement linux and windows compilation in a single function. This will make future support for more OS or windows-arm more difficult. Too many if branches will also degrade code readability. Perhaps you can separate the logic for different operating systems into independent functions.
|
Yes, it's necessary to address the problem. However, since it might be a significant task, I've opened an issue to investigate further. #5124 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @Shelley-BaoYue
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/milestone v1.16 |
…-#5049-upstream-release-1.15 Automated cherry pick of #5049: feat: update to support release windows/amd64
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added support for windows/amd64 release, including components edgecore and keadm
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This pr depends on #4968
Does this PR introduce a user-facing change?: