Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go mod to prepare for mapper upgrade #5308

Merged
merged 1 commit into from Dec 15, 2023

Conversation

wbc6080
Copy link
Contributor

@wbc6080 wbc6080 commented Dec 13, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds the go.mod file to _template and makes changes to generate.sh.
In this PR, make generate will only generate files in the _template directory, and the original pkg files will be referenced in the form of packages to facilitate mapper upgrades.
In addition, this PR fix the module of mapper-framework to the path of mapper-framework repo to correct reference.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This PR is mainly the preparation work for mapper upgrade. After merge and sync to mapper-framework repo, we need to correctly create tags for the mapper-framework repo. On this basis, subsequent PRs will modify the way pkg is referenced in _template

Does this PR introduce a user-facing change?:


Signed-off-by: wbc6080 <wangbincheng4@huawei.com>
@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 13, 2023
@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2023
@cl2017
Copy link
Contributor

cl2017 commented Dec 15, 2023

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023
@kubeedge-bot kubeedge-bot merged commit 7cb9a17 into kubeedge:master Dec 15, 2023
18 checks passed
@wbc6080 wbc6080 deleted the mapper-upgrade branch December 28, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants