Clean up of some issues. #20
Conversation
2. Add a notice for opcua usage.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
size/S
pkg/opcua/README.md
Outdated
|
|
||
| There's a bug about gopcua library. https://github.com/gopcua/opcua/issues/410. | ||
| If you want to use username&password mode, please modify the file as this: | ||
| vendor/github.com/gopcua/opcua/uasc/secure_channel_crypto.go line 67: |
| @@ -51,10 +51,10 @@ status: | |||
| reported: | |||
| metadata: | |||
| timestamp: '1550049403598' | |||
| type: integer | |||
| type: int | |||
There was a problem hiding this comment.
I am not quite sure if we have any testcase to verify this.
There was a problem hiding this comment.
Yes, there's no automated test to verify mappers. It's on the TODO list.
There was a problem hiding this comment.
file edge/pkg/devicetwin/dtcommon/util.go function ValidateValue check the metadata type, it should be int, but not integer
kubeedge-bot
added
the
needs-rebase
|
@sailorvii: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubeedge-bot
added
size/M
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #19 #9