-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add implement dmi interface #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the binary mappers/modbus-dmi/bin/modbus-dmi
} | ||
|
||
var twins []*dmiapi.Twin | ||
for _, twin := range msg.Twin { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can make it a function in pkg/util/parse/type.go
Signed-off-by: cl2017 <chenlin.liu@daocloud.io>
Signed-off-by: cl2017 <chenlin.liu@daocloud.io>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the umbrella issue for DMI is kubeedge/kubeedge#3760 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add implement dmi interface
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer: