Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support showing knowledge base #406

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Support showing knowledge base #406

merged 4 commits into from
Jun 13, 2023

Conversation

jaypume
Copy link
Member

@jaypume jaypume commented May 5, 2023

  1. Support showing knowledge base in crd status field.
  2. Add knowledge base types definition.
  3. Add autogen crd related code based on types.go.
  4. Add some comment.

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 5, 2023
@jaypume jaypume force-pushed the feature-knowledge-base branch 9 times, most recently from 499b356 to 9ebdf0b Compare June 9, 2023 08:08
@kubeedge-bot kubeedge-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2023
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2023
@jaypume
Add knowledge base types definition
e1c920a 
Signed-off-by: Jie Pu <i@jaypu.com>
@jaypume
Add autogen code based on types.go
f996a83 
Signed-off-by: Jie Pu <i@jaypu.com>
@jaypume
Support showing knowledge base in crd status field
0e43075 
Signed-off-by: Jie Pu <i@jaypu.com>
@jaypume jaypume requested a review from Poorunga June 12, 2023 09:25
Poorunga
Poorunga reviewed Jun 12, 2023
View reviewed changes
pkg/localcontroller/managers/lifelonglearning/lifelonglearningjob.go Outdated
@@ -281,6 +281,10 @@ func (lm *Manager) evalTask(job *Job) error {
jobConfig.UniqueIdentifier, err)
}

// 这个触发器是指，LC已经告诉GM可以触发Eval worker了，
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please comment by english

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment has been changed to English.

Poorunga
Poorunga reviewed Jun 12, 2023
View reviewed changes
pkg/globalmanager/controllers/lifelonglearning/upstream.go Outdated
numberOfSamples := 0
aiModels := sednav1.AIModels{}
aiclasses := sednav1.AIClasses{}
aiclasses.ListOfAIClasses = cd.Output.Models[0].Classes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended that slice lengths be allocated in advance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following line has beed added to optimize slice allocation.
aiModels.ListOfAIModels = make([]sednav1.AIModel, 0, len(cd.Output.Models))

@seveirbian
Copy link

/lgtm

@kubeedge-bot
Copy link
Collaborator

@seveirbian: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jaypume
update generated crd code and fix ci
6753b22 
Signed-off-by: Jie Pu <i@jaypu.com>
@Poorunga
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@jaypume
Copy link
Member Author

jaypume commented Jun 13, 2023

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@kubeedge-bot kubeedge-bot merged commit 3e8de61 into kubeedge:main Jun 13, 2023
11 checks passed
@jaypume jaypume deleted the feature-knowledge-base branch August 9, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Poorunga Poorunga Poorunga left review comments

@MooreZheng MooreZheng Awaiting requested review from MooreZheng

@TymonXie TymonXie Awaiting requested review from TymonXie

Assignees

@Poorunga Poorunga

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaypume @seveirbian @kubeedge-bot @Poorunga