setup viaduct, provide basic version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sids-b
requested changes
Mar 25, 2019
There was a problem hiding this comment.
Please use dep to manage vendor so that we don't have test files/unwanted packages in vendor.
Please refer https://github.com/golang/dep
examples/chat/server.go
Outdated
| "crypto/x509" | ||
| "encoding/pem" | ||
| "fmt" | ||
| "github.com/kubeedge/viaduct/pkg/api" |
There was a problem hiding this comment.
please place this package with the batch of vendor package.
|
cc @qizha for review |
|
@glenn-lg , can you please seperate out the commits. 1 for vendor and 1 for source code ? |
|
cc @qizha for review and merging |
|
LGTM |
swx457056
added a commit
to sandhyaravi/viaduct
that referenced
this pull request
Apr 25, 2019
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup viaduct, provide basic version