Telemetry properties cluster_id, cluster_type, and kubefirst_team #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertkeithrippetoe
requested review from
jarededwards,
CristhianF7 and
johndietz
|
I think this is in a good state, still need to check how machineId propagates in other repos |
This was referenced Jan 31, 2023
johndietz
reviewed
Feb 1, 2023
|
Requirements have changed, now also adjusting code to accommodate cloud_provider and git_provider |
robertkeithrippetoe
added a commit
that referenced
this pull request
Feb 13, 2023
) * fix(docs): updat link in install page to explore page * feat(opentel): new properties for opentel metrics * feat: update unit tests * feat: update field initialization for NewTelemetry * feat: change UUID in tests to a static generated UUID * feat: implement variadic optional functions for flexibility * fix: add parameters for service test * fix: reorder fields, add comment for optional param * fix: cluster-id rename * feat(telemetry): adding new fields, checking provider values * feat(telemetry): refactor getting git provider * feat(telemetry): update all runs to accomodate new provider fields * feat(telemetry): update telemtry unit tests with provider fields * feat(telemetry): update properties with providef fields * feat: detokenize new params for console * fix(telemetry): get gitprovider from viper --------- Co-authored-by: Robert Keith Rippetoe <robertkeithrippetoe@MacBook-Pro.domain> Co-authored-by: Robert Keith Rippetoe <robertkeithrippetoe@Roberts-MBP.domain> Co-authored-by: Keith Rippetoe <keith@kubefirst.io> Co-authored-by: CristhianF7 <CristhianF7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new properties and deprecate machine_id in favor of a new UUID cluster_id