Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude log helper output from specific subcommands. #1255

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Exclude log helper output from specific subcommands. #1255

merged 2 commits into from
Feb 2, 2023

Conversation

echoboomer
Copy link
Contributor

Addresses: #1221

Signed-off-by: echoboomer <scott@echoboomer.net>
Signed-off-by: echoboomer <scott@echoboomer.net>
@echoboomer
Copy link
Contributor Author

This does also prevent output re: log helper when only the root command is called.

Copy link
Member

@jarededwards jarededwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @echoboomer !

@jarededwards jarededwards merged commit 73a4417 into kubefirst:main Feb 2, 2023
@echoboomer echoboomer deleted the echoboomer/adj-log-helper-output branch February 3, 2023 01:58
robertkeithrippetoe pushed a commit that referenced this pull request Feb 13, 2023
* Exclude log helper output from specific subcommands.

Signed-off-by: echoboomer <scott@echoboomer.net>

* Fix bug where no additional args caused panic.

Signed-off-by: echoboomer <scott@echoboomer.net>

---------

Signed-off-by: echoboomer <scott@echoboomer.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants