Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UT #1321

Merged
merged 1 commit into from
Mar 1, 2023
Merged

fix: UT #1321

merged 1 commit into from
Mar 1, 2023

Conversation

6za
Copy link
Contributor

@6za 6za commented Feb 28, 2023

Solve UT issues:

internal/gitlabcloud/gitlab.go:31:2: (*github.com/rs/zerolog.Event).Msgf format %s has arg subGroupID of wrong type int

How it was validated:

git_6za clone git@github.com:org-demo-6za-2/kubefirst.git main 
cd main 

docker run \
  -v  go-pkg:/go/pkg \
  -it --name kubefirst-main  \
  --dns="1.0.0.1" --dns="208.67.222.222" --dns="8.8.8.8" \
  -v $(PWD):/home/developer/app \
  --platform linux/amd64 \
  -e "TERM=xterm-256color" \
   6zar/cobra_dev

export ARTIFACT_SOURCE=`pwd`
go test ./...  --short -v

Results:

go test ./...  --short -v ; echo $?

?     github.com/kubefirst/kubefirst  [no test files]
?     github.com/kubefirst/kubefirst/cmd  [no test files]
?     github.com/kubefirst/kubefirst/cmd/civo [no test files]
?     github.com/kubefirst/kubefirst/cmd/k3d  [no test files]
?     github.com/kubefirst/kubefirst/cmd/local  [no test files]
?     github.com/kubefirst/kubefirst/configs  [no test files]
?     github.com/kubefirst/kubefirst/internal/addon [no test files]
=== RUN   TestArgoCDLivenessIntegration
    argocd_test.go:17: skipping integration test
--- SKIP: TestArgoCDLivenessIntegration (0.01s)
=== RUN   TestArgoWorkflowLivenessIntegration
    argocd_test.go:52: skipping integration test
--- SKIP: TestArgoWorkflowLivenessIntegration (0.00s)
PASS
ok    github.com/kubefirst/kubefirst/internal/argocd  (cached)
?     github.com/kubefirst/kubefirst/internal/argocdModel [no test files]
...
    ngrok_test.go:17: skipping end to tend test
--- SKIP: TestNgrokGitHubWebhookIntegration (0.00s)
=== RUN   TestVaultLoginEndToEnd
    vault_test.go:29: skipping end to tend test
--- SKIP: TestVaultLoginEndToEnd (0.00s)
PASS
ok    github.com/kubefirst/kubefirst/tests  (cached)
0

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@jarededwards jarededwards merged commit 05e4cd9 into kubefirst:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants