Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update git flags, minor vault fixes #1348

Merged
merged 1 commit into from
Mar 10, 2023
Merged

feat: update git flags, minor vault fixes #1348

merged 1 commit into from
Mar 10, 2023

Conversation

echoboomer
Copy link
Contributor

  • Updates --github-owner to --github-user for k3d.
  • Updates --github-owner to --github-org for Civo.
  • Updates --gitlab-owner to --gitlab-group for both.
  • Adds progress printer for CoreDNS wait step for Civo to avoid no output while it waits.
  • Adds some more wait logic to the Vault unseal process.

These commands were used for testing:

go run . k3d create --git-provider gitlab --gitlab-group kubefirstdev
go run . k3d create --git-provider github --github-user echoboomer (GITHUB_TOKEN set)
go run . k3d create (no GITHUB_TOKEN set)

go run . civo create \
    --alerts-email scott@kubeshop.io \
    --domain-name k-ray.space \
    --git-provider github \
    --github-org k-ray-space \
    --cluster-name k-ray-space
go run . civo create \
    --alerts-email scott@kubeshop.io \
    --domain-name k-ray.space \
    --git-provider gitlab \
    --gitlab-group kubefirstdev \
    --cluster-name k-ray-space

@echoboomer echoboomer merged commit ee8bc3b into main Mar 10, 2023
@echoboomer echoboomer deleted the feat-git-flags branch March 10, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants