This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Common job controller library #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrytangyuan
approved these changes
Apr 4, 2019
job_controller/job_controller.go
Outdated
| // e.g. 15s, 30s, 60s, 120s... | ||
| ReconcilerSyncLoopPeriod metav1.Duration | ||
|
|
||
| // Enable gang scheduling by kube-arbitrator |
There was a problem hiding this comment.
kube-arbitrator -> kube-batch
job_controller/pod.go
Outdated
|
|
||
| } | ||
|
|
||
| // When a pod is updated, figure out what tfjob/s manage it and wake them up. |
There was a problem hiding this comment.
tfjob can be changed to be more generic name here
job_controller/pod.go
Outdated
| logger := commonutil.LoggerForPod(pod, jc.Controller.GetAPIGroupVersionKind().Kind) | ||
|
|
||
| if job == nil { | ||
| // If this is a TFJob pod |
There was a problem hiding this comment.
TFJob -> more generic name
johnugeorge
reviewed
Apr 4, 2019
test_util/v1/util.go
Outdated
| } | ||
|
|
||
| // ConvertTFJobToUnstructured uses JSON to convert TFJob to Unstructured. | ||
| func ConvertTFJobToUnstructured(testJob *testjobv1.TestJob) (*unstructured.Unstructured, error) { |
johnugeorge
reviewed
Apr 4, 2019
test_job/v1/types.go
Outdated
|
|
||
| // +genclient | ||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
| // +resource:path=tfjob |
johnugeorge
reviewed
Apr 4, 2019
test_util/v1/const.go
Outdated
|
|
||
| // DefaultPortName is name of the port used to communicate between PS and | ||
| // workers. | ||
| DefaultPortName = "tfjob-port" |
|
Fixed the comments, please take a look again. |
|
/unassign @gaocegege |
|
/assign @gaocegege |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
georgkaleido
pushed a commit
to georgkaleido/common
that referenced
this pull request
Jun 9, 2022
Co-authored-by: Paul Angerer <dabauxi@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of kubeflow/training-operator#960
This is the common library functions copied from tf-operator. Mapping is as follows:
Also added a test_job to represent generic training jobs. Originally all the tests were written using tfjob, but this repo cannot take a dependency on tf-operator.
The other files are auto-generated for the testjob custom resource.
This change is