Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proccess & tooling to triage issues #280

Closed
jlewi opened this issue Jul 24, 2019 · 9 comments
Closed

Proccess & tooling to triage issues #280

jlewi opened this issue Jul 24, 2019 · 9 comments
Labels
community/maintenance kind/feature priority/p1
Projects
engprod 0.7.0

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 24, 2019

We need a process and tools to triage GitHub issues.

Here's my initial proposal

The following needs to be true for an issue to be considered triaged

  • It has one the labels ("bug", "question", "enhancement")
  • It has a priority
  • If its P0/P1 it should be added to a kanban board
  • It has at least one "area" label

I will create a simple script that iterates over our issues and does the following

  1. Adds untriaged issues to a project used for triaging issues

    • I think a project is better than a label because we can potentially use cards to keep track of an issue; e.g. if there is some question about an issue and it needs to be discussed at the community meeting

  2. Add a comment on the issue explaining what criterion are missing for the issue to be considered triaged
@jlewi jlewi added this to To do in engprod via automation Jul 24, 2019
@jlewi jlewi added this to To Do in 0.7.0 via automation Jul 24, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label improvement/enhancement to this issue, with a confidence of 0.64. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented Jul 24, 2019

Do GitHub issues have a notion of status checks like PRs do?
It might be nice if we could make triage a status that changes over time (like tests passing) rather than cluttering the issue with comments.

@jlewi jlewi mentioned this issue Jul 25, 2019
Open
@jlewi
Copy link
Contributor Author

jlewi commented Jul 25, 2019

somecomment

3 similar comments
@jlewi
Copy link
Contributor Author

jlewi commented Jul 25, 2019

somecomment

@jlewi
Copy link
Contributor Author

jlewi commented Jul 25, 2019

somecomment

@jlewi
Copy link
Contributor Author

jlewi commented Jul 25, 2019

somecomment

@jlewi
Copy link
Contributor Author

jlewi commented Jul 25, 2019

Issue needs triage:
Issue needs an area label
Issues with priority in ['priority/p0', 'priority/p1'] need to be assigned to a project

jlewi added a commit to jlewi/Issue-Label-Bot that referenced this issue Jul 26, 2019
@jlewi
Create a python script to triage issues
e978921 
* An issue is considered triaged if certain criterion such as labels are set.

See: kubeflow/community#280
jlewi added a commit to jlewi/Issue-Label-Bot that referenced this issue Jul 26, 2019
@jlewi
Create a python script to triage issues
7ea0cd7 
* An issue is considered triaged if certain criterion such as labels are set.

See: kubeflow/community#280

* Issues needing triage are added to the "Needs Triage" Kanban board.

* Update issue label bot to use "improvement/enhancement" for the enhancement
  type.

Remove partial file.
@jlewi jlewi mentioned this issue Jul 26, 2019
Merged
k8s-ci-robot pushed a commit to kubeflow/code-intelligence that referenced this issue Jul 26, 2019
@jlewi @k8s-ci-robot
Create a python script to triage issues (#22)
89878f5 
* Create a python script to triage issues

* An issue is considered triaged if certain criterion such as labels are set.

See: kubeflow/community#280

* Issues needing triage are added to the "Needs Triage" Kanban board.

* Update issue label bot to use "improvement/enhancement" for the enhancement
  type.

Remove partial file.

* Address comments.
jlewi added a commit to jlewi/community that referenced this issue Jul 26, 2019
@jlewi
Proposal for triaging GitHub issues
cab26ce 
Related to: kubeflow#280
This was referenced Jul 26, 2019
Merged
Merged
@hamelsmu
Copy link
Member

hamelsmu commented Aug 6, 2019

@jlewi I'm responding to this:

Do GitHub issues have a notion of status checks like PRs do?
It might be nice if we could make triage a status that changes over time (like tests passing) rather than cluttering the issue with comments.

☝️ we could fake it with issue-labels (ex: status/<> ) but there are no checks like there are for PRs

k8s-ci-robot pushed a commit that referenced this issue Aug 13, 2019
@jlewi @k8s-ci-robot
Proposal for triaging GitHub issues (#281)
0c66b84 
* Proposal for triaging GitHub issues

Related to: #280

* Add more notes about the toooling that now exists.
@jlewi
Copy link
Contributor Author

jlewi commented Aug 26, 2019

I'm closing this issue because we have

  • A doc for the process
  • Tools to add/remove issues

We can open up more issues as needed.

@jlewi jlewi closed this as completed Aug 26, 2019
engprod automation moved this from To do to Done Aug 26, 2019
0.7.0 automation moved this from To Do to Done Aug 26, 2019
woop pushed a commit to woop/community that referenced this issue Nov 16, 2020
@lluunn @k8s-ci-robot
Add doc for rollout model (kubeflow#280)
dc454f4 
* Add doc for rollout model

* address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community/maintenance kind/feature priority/p1
Projects
No open projects
0.7.0
  
Done
engprod
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @hamelsmu