-
Notifications
You must be signed in to change notification settings - Fork 244
WG Data proposal #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WG Data proposal #673
Conversation
|
I am very strongly opposed to using the name My proposal for the name is: Where "data" can mean both actual data (spark) and metadata (model registry). We can also split it up in the future, if the members who are maintaining these components diverge. |
very well noted @thesuperzapper , as also marked here: I just wanted to have a branch where to start collecting this kind of feedback in a non-sparse way and also to report back to you and the group on the progress on Tuesday meetings. |
|
@thesuperzapper how about we make it more explicit |
|
As it currently stands, this WG does not meet the requirement for diverse leadership given all chairs come from one company (IBM - which owns RedHat). |
|
@thesuperzapper Andrey is listed as a Chair, he's from Apple |
|
noticing only now it was not marked as Draft PR despite being my intent:
my sincerest apologies. Marked as Draft PR per original message in thead. |
|
@thesuperzapper Is there a minimum number of companies to compose the chair to make the WG eligible? |
|
While there is no specific number requirement, the steering comity must approve the new WG (currently, @jbottum @james-jwu) in line with the community's interests. I would expect at least some concern with having 4 leads from one company and only 1 from another. For reference, here is the lifecycle and other info about forming a working group: Also, there are only meant to be 2-3 chairs, some other WGs have more, but in most cases, there are 2 active members and we just need to formally clean up the inactive chairs. |
|
Also, some of the proposed chairs are not even current Kubeflow org members, so are ineligible unless they go through that process first: |
|
Thank you for the references! Those are valid points though, and I'll see how we can work on the eligibility topic as well as your concerns. |
|
As Ricardo noted, thanks ! Is there guidance for deputies to keep work WG ongoing during leaves, please? As noted, will work out to account all the feedback received; thank you those are very helpful |
|
Thank you for starting this @tarilabs! Let's collaborate together on this PR for the WG Charter and Name. Please provide your suggestion on how we should name this WG that initially will have Spark Operator and Model Registry component. A few initial suggestions if WG Lifecycle is too ambitious:
This is valid concern @thesuperzapper. We can add folks from Spark Operator maintainers to this WG |
|
cc @kubeflow/wg-training-leads |
|
I would request "WG ML Lifecycle" if the purpose of the group is to house things in the MLOps orbit that don't have a more specific working group yet so they can "incubate". Data Preparation, Feature Store, and Model Registry being 3 examples that have been recently discussed that likely aren't big enough yet to have their own working group. I guess one key aspect here is to consider how new efforts can happen without the overhead of setting-up a new working group for each one until it is truly merited and bandwidth is available. Is there a process that exists for refactoring a topic out of one working group to a new working group? |
|
Kubeflow seems to be entering a new growth phase. The community needs a structure to support add-on components (Spark, Ray, Model Registry, Feature Store, etc). We want to encourage contributors and users to meet, discuss, experiment, decide, store code and produce documentation with a goal that integrations will help both Kubeflow and the add-on projects. We need to minimize overhead. We need to set expectations (of support...to/from Kubeflow and for users) especially if we are experimenting and trying to find market acceptance. Most importantly, we need active user participation, comment and leadership. I want to move this forward...I am a +1 to adding a single umbrella WG for all of these projects to get things moving. @james-jwu would you please provide your thoughts |
|
I think that the name
Also, I am still very against Separately to the discussion around names, I think we should confirm that the maintainers of these various components are actually overlapping, otherwise it will make it difficult for this "mega working group" to function. |
|
+1 to @thesuperzapper I would suggest voting for |
|
New commit ae188fe incorporates some feedback received around:
will keep posted during KF Community meeting on any further updates. |
|
Just so we are clear, I think |
quote: Given current discussions with Feast, I recommend we start the Data WG without them and update the WG later. ref: kubeflow#673 (comment) This reverts commit fa3c318. Signed-off-by: tarilabs <matteo.mortari@gmail.com>
this is one of those times I'm glad we kept tidy in this PR history commits, done with 77d772d |
|
@tarilabs Please can you rebase your PR, so we can merge it ? |
yes I'm on it 🙏 |
|
one moment sorry |
resolve conflict on OWNER_ALIASES from upstream/master Signed-off-by: tarilabs <matteo.mortari@gmail.com>
c3f3319 to
37b9883
Compare
|
/remove-hold |
andreyvelich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tarilabs!
Just small updates.
| name: Matteo Mortari | ||
| company: Red Hat | ||
| meetings: | ||
| - description: KF Model Registry community meeting (US/EMEA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add the Spark Operator call please ?
cc @vara-bonthu @ChenYi015 @nabuskey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmk if the 89ddd0a satisfies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarilabs can you run make generate to re-generate the readme ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's been a while I didn't look into this PR, thanks for the reminder 🙏 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run make generate to re-generate the readme
done with 8f3f780
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
sourced from https://github.com/kubeflow/community/blob/2f819b1a224da35692f86ab6b70e01cd02c385b2/calendar/calendar.yaml#L163-L184 Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
andreyvelich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally we can move forward with this PR 🎉
Thanks everyone!
/lgtm
/approve
/hold
@tarilabs Feel to un-hold, please also create PR in the Kubeflow website to update WG list: https://www.kubeflow.org/docs/about/community/#kubeflow-working-groups
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
thank you @andreyvelich for the confirmation! /remove-hold |
followups to kubeflow/community#673 (review) Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
followups to kubeflow/community#673 (review) Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
I'm following up on action item: raise WG proposal to Kubeflow per yesterday's Model Registry meeting (recording timestamp).
As discussed in KF community meeting.
Main links:
👉 I'm starting to raise a draft PR in order to "seed/bootstrap" the work in raising the request to form the WG--using a draft PR give us a branch we can collaborate on between stakeholders @andreyvelich @Tomcli @dhirajsb @rimolive
This also give us a medium we can keeps-tab-on so to report back on progress during Tuesdays' community plenary meetings, wdyt?