[pytorch_mnist] Automate image build #490

dsdinter · 2019-01-27T18:37:42Z

First step to fix #312

TODO
Add E2E test to train model
Add E2E test to deploy model
Add E2E test to predict digits.

This change is

googlebot · 2019-02-03T16:19:21Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

googlebot · 2019-02-03T20:50:17Z

CLAs look good, thanks!

dsdinter

Will use GCP Cloud builder for Docker https://github.com/GoogleCloudPlatform/cloud-builders

pytorch_mnist/Makefile

jlewi · 2019-02-19T21:11:46Z

Just an FYI; if you want me to review this remove WIP from the title. I assume if WIP is in the title its not ready for review.

jlewi · 2019-03-26T02:52:09Z

/assign @texasmichelle
/assign @johnugeorge

@johnugeorge Since you are one of the primary maintainers of PyTorch do you want to review this PR?

johnugeorge · 2019-03-27T16:54:20Z

With the upcoming release 0.5, v1alpha2 won't be supported. Supported versions would be v1beta1 and v1beta2

Keep postsubmit jobs as original release job to push images to examples registry

…able E2E tests

kubeflow/pytorch-operator#108 is implemented

As per kubeflow/pytorch-operator#108

Rename testing package as kubeflow/training-operator#945 Added correct path to import test framework from tf-operator

…v1beta1/v1beta2 to support Kubeflow 0.5 - Refactor training manifests from v1alpha2 to v1beta2 - Update documents

dsdinter · 2019-05-01T13:13:31Z

Hi @johnugeorge , thanks for the feedback. I bumped up versions to support v0.5.
I would appreciate your help to figure out the best way to test train and deploy jobs for the pytorch model.
I believe the idea at the moment is to use the test_runner module from tf-operator but wondering if we can use something like pytest to reduce dependencies between components.

Thanks.

jlewi · 2019-05-03T12:48:15Z

Yes. You can use the pytest module. I believe mnist TF is using tat now at least for deploy.
https://github.com/kubeflow/examples/blob/master/mnist/testing/predict_test.py

@johnugeorge @dsdinter what's the best way to push through this PR. It looks like this PR is doing three things

Setup CI for the docker images.
Adding E2E test for training
Adding E2E test for prediction.

Would breaking this up into 3 smaller PRs help make progress?

johnugeorge · 2019-05-03T13:40:08Z

I have the same opinion. @dsdinter what do you think?

dsdinter · 2019-05-03T16:08:19Z

I agree, part 1. is complete I believe.
Happy to change the test modules as dummy ones to pass always, then close this PR, let me change the title.

jlewi · 2019-05-03T23:01:37Z

I'll let @johnugeorge handle reviewing this PR; if you need me for something let me know.

Remove no longer used test_data and conftest

dsdinter · 2019-05-06T21:32:39Z

Thanks @jlewi , @johnugeorge please review and let me know if you are happy to approve.

Kind regards.

johnugeorge · 2019-05-07T12:23:32Z

Looks good to me. Anything pending in this?

johnugeorge · 2019-05-08T07:08:29Z

/lgtm

dsdinter · 2019-05-08T15:09:34Z

/approve

dsdinter · 2019-05-08T15:11:21Z

@texasmichelle @jlewi feel free to approve this PR.

Thanks.

texasmichelle · 2019-06-14T23:03:59Z

Thanks to you both for working on this!

/approve

k8s-ci-robot · 2019-06-14T23:04:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsdinter, texasmichelle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [texasmichelle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the do-not-merge/work-in-progress label Jan 27, 2019

k8s-ci-robot requested review from cwbeitel and jlewi January 27, 2019 18:37

k8s-ci-robot added size/M size/XXL and removed size/M labels Jan 27, 2019

dsdinter force-pushed the pytorch-nmist-tests branch from e6ca26b to 8863deb Compare February 3, 2019 20:50

dsdinter force-pushed the pytorch-nmist-tests branch from 8863deb to 4f5e4ac Compare February 3, 2019 23:20

dsdinter commented Feb 13, 2019

View reviewed changes

pytorch_mnist/Makefile Outdated Show resolved Hide resolved

dsdinter force-pushed the pytorch-nmist-tests branch 2 times, most recently from 48f6877 to 7e24499 Compare February 17, 2019 12:27

dsdinter changed the title ~~[WIP] [pytorch_mnist] Implement E2E tests~~ [pytorch_mnist] Implement E2E tests Feb 19, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress label Feb 19, 2019

jlewi mentioned this pull request Mar 10, 2019

[mnist_pytorch] Implement E2E tests #312

Closed

jlewi removed the request for review from cwbeitel March 26, 2019 02:51

k8s-ci-robot assigned johnugeorge and texasmichelle Mar 26, 2019

dsdinter added 8 commits May 1, 2019 12:02

Add build and test presubmit jobs for Pytorch nmist example

e5057bc

Keep postsubmit jobs as original release job to push images to examples registry

Refactor all jobs like mnist and GIS, will drop using release jobs

ba2dfa8

Implement test scripts and Ksonnet artifacts from mnist example to en…

9e8d63a

…able E2E tests

Remove release components as they are no longer used

7b955b2

Refactor YAML manifests as Ksonnet components

b005475

Commented out calls to tf-util until

b08496a

kubeflow/pytorch-operator#108 is implemented

Refactor to PytorchJob

75007dc

Update documentation to submit training jobs from Ksonnet

12e5668

dsdinter added 6 commits May 1, 2019 12:02

Leverage tf-operator test framework for test_runner

108efee

As per kubeflow/pytorch-operator#108

Consolidate testing imports

aae5c65

Rename testing package as kubeflow/training-operator#945 Added correct path to import test framework from tf-operator

Add test framework in PYTHONPATH in build_template

7535667

Remove old release jobs to build images

7224510

Update stepimage to same as GIS example

d474d51

Bump up supported Pytorch operator versions from v1alpha2/v1beta1 to …

1fa7f80

…v1beta1/v1beta2 to support Kubeflow 0.5 - Refactor training manifests from v1alpha2 to v1beta2 - Update documents

dsdinter force-pushed the pytorch-nmist-tests branch from 12a4ccb to 1fa7f80 Compare May 1, 2019 11:03

dsdinter added 2 commits May 1, 2019 12:11

Update KF cluster version to latest to run tests

e36641a

Update KF cluster zone

c9fbef8

Add pylint exception while importing test_runner class from tf-operator

dcb3430

dsdinter changed the title ~~[pytorch_mnist] Implement E2E tests~~ [pytorch_mnist] Automate image build May 3, 2019

jlewi removed their request for review May 3, 2019 23:01

dsdinter added 2 commits May 5, 2019 23:56

Pass dummy tests to train, deploy and predict

17635a6

Remove no longer used test_data and conftest

Pass dummy tests to train, deploy and predict

5b265bf

Remove no longer used test_data and conftest

k8s-ci-robot added the lgtm label May 8, 2019

k8s-ci-robot added the approved label Jun 14, 2019

k8s-ci-robot merged commit 7a6dc7b into kubeflow:master Jun 14, 2019

dsdinter deleted the pytorch-nmist-tests branch June 28, 2019 14:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pytorch_mnist] Automate image build #490

[pytorch_mnist] Automate image build #490

dsdinter commented Jan 27, 2019 •

edited

googlebot commented Feb 3, 2019

googlebot commented Feb 3, 2019

dsdinter left a comment

jlewi commented Feb 19, 2019

jlewi commented Mar 26, 2019

johnugeorge commented Mar 27, 2019

dsdinter commented May 1, 2019

jlewi commented May 3, 2019

johnugeorge commented May 3, 2019

dsdinter commented May 3, 2019

jlewi commented May 3, 2019

dsdinter commented May 6, 2019

johnugeorge commented May 7, 2019

johnugeorge commented May 8, 2019

dsdinter commented May 8, 2019

dsdinter commented May 8, 2019

texasmichelle commented Jun 14, 2019

k8s-ci-robot commented Jun 14, 2019

[pytorch_mnist] Automate image build #490

[pytorch_mnist] Automate image build #490

Conversation

dsdinter commented Jan 27, 2019 • edited

googlebot commented Feb 3, 2019

googlebot commented Feb 3, 2019

dsdinter left a comment

Choose a reason for hiding this comment

jlewi commented Feb 19, 2019

jlewi commented Mar 26, 2019

johnugeorge commented Mar 27, 2019

dsdinter commented May 1, 2019

jlewi commented May 3, 2019

johnugeorge commented May 3, 2019

dsdinter commented May 3, 2019

jlewi commented May 3, 2019

dsdinter commented May 6, 2019

johnugeorge commented May 7, 2019

johnugeorge commented May 8, 2019

dsdinter commented May 8, 2019

dsdinter commented May 8, 2019

texasmichelle commented Jun 14, 2019

k8s-ci-robot commented Jun 14, 2019

dsdinter commented Jan 27, 2019 •

edited