Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

ISTIO sidecar adds difficulty when talking to resources outside the cluster #385

Closed
gabrielwen opened this issue Oct 7, 2019 · 6 comments

Comments

@gabrielwen
Copy link

Currently all jobs created by Fairing has an ISTIO sidecar and default behavior is to block all outgoing traffic. During the hackathon we disabled it by adding an annotation. Do we want to promote this approach?

  • What is the side effect of disabling ISTIO sidecar?
  • Should we make ISTIO sidecar an optional deployment instead of making it default?
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@nrchakradhar
Copy link
Contributor

@gabrielwen Can you please provide some more information on how istio-side-car is auto injected by fairing? My understanding for fairing is limited, but I thought side car injection was based on how Istio was installed and for what all namespaces side car injection should be enabled by default. Please let me know if my understanding is correct or not?

@gabrielwen
Copy link
Author

hmm, I agree but I just found out istio sidecar is disabled by default: #348

need to find out why my deployments still had it.

@abhi-g
Copy link
Member

abhi-g commented Nov 11, 2019

#399 resolves some other places where istio sidecar was disabled for example for job deployers. Can you please verify if your issue is resolved @gabrielwen

@gabrielwen
Copy link
Author

/close

@k8s-ci-robot
Copy link
Contributor

@gabrielwen: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants