Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WG Deployment and Manifests #382

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

PatrickXYS
Copy link
Member

Given WG deployments and manifests have established and PRs have merged.

kubeflow/community#402

kubeflow/community#435

Creating two teams to own kfctl and manifests repo.

@kubeflow-bot
Copy link

This change is Reviewable

@PatrickXYS
Copy link
Member Author

/cc @Bobgy @jlewi @yanniszark @Jeffwan

@yanniszark
Copy link
Contributor

This is interesting!
So the procedure is something like:

  1. Add new workgroup in kubeflow/community.
  2. Add group in internal/acls. (this could be automated)
  3. Add leads to OWNERS files in the respective repos (this can't really be automated since not all leads are relevant to all projects).

@PatrickXYS is there a place where this procedure is documented.
Also, I am surprised that we give write access to repos. Why is this needed?
Shouldn't everything go through OWNERS files and the k8s-ci-bot or am I missing something?

@jlewi
Copy link
Contributor

jlewi commented Nov 4, 2020

@yanniszark it should probably be documented somewhere in community; probably in one of these docs.
https://github.com/kubeflow/community/tree/master/wgs

Also, I am surprised that we give write access to repos

I believe write access is needed to cut branches and releases. I consider this as a stop gap. Giving more and more folks write access isn't going to be scalable but for now its ok.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0fb0fda into kubeflow:master Nov 4, 2020
@PatrickXYS PatrickXYS deleted the yao_aws_account branch November 4, 2020 20:13
@yanniszark
Copy link
Contributor

@jlewi thanks for the info :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants